Reset session info when connection state is not connected #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karriebear
force-pushed
the
update-sessionid
branch
from
b90b259
to
477cfbf
Compare
akrolsmir
approved these changes
Nov 17, 2020
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 24, 2020
* develop: widgets.py: add type annotations (streamlit#2383) Lazy import S3Storage, so boto3 isn't always imported (streamlit#2375) Require `Sphinx">=3.0"` instead of bumping a fixed version (streamlit#2362) Fix Markdown issues found (streamlit#2381) Reset session info when connection state is not connected (streamlit#2364) Convert App to Emotion (streamlit#2353) Update develop_streamlit_components.md (streamlit#2357)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Fixes #2363
Description:
Previously, we had an initialize message that was run on each new session. This was removed in #2317 and now all the initialization is done only once per page load.
This is a change from our previous metrics and causes issues for file uploader. Reverting back to the previous behavior so that each new session is re-initializated. Instead of tracking state on the server side like before, we now clear out SessionInfo (stored on the client side) when the client is no longer connected with the server.
This does not address any changes to metrics to improve our initialization/optimization of metrics. It is only a revert back to previous behavior. Any metric changes can be handled by a separate issue.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.