Feature/sudoless metrics #2605
Merged
Feature/sudoless metrics #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
approved these changes
Jan 15, 2021
| with open("/var/lib/dbus/machine-id", "r") as f: | ||
| machine_id = f.read() | ||
|
|
||
| return machine_id |
There was a problem hiding this comment.
All looks great! Might be nice to break out these file paths into constants cause I see them around everywhere. Might help avoid an accidental misspelling.
That being said, this is very straightforward and might not need to be over DRYed.
Step 2 of the metrics user ID improvement plan.
Duplicates of the v1 tests, since those covered the cases that remain in v3, and we will remove v1 and its tests later. Also fix formatting of some python files.
AnOctopus
force-pushed
the
feature/sudoless-metrics
branch
from
92d66b8
to
dfa5633
Compare
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jan 19, 2021
* develop: Feature/sudoless metrics (streamlit#2605) Have st.number_input warn user of mismatched type and format string (streamlit#2604) Remove extra period from sentence (streamlit#2601) Revert "Deploy button front (streamlit#2552)" (streamlit#2599) Fix slider UX (streamlit#2596)
CFrez
pushed a commit
to CFrez/streamlit
that referenced
this pull request
Jan 21, 2021
* Add and use sudoless machine id getter for metrics Step 2 of the metrics user ID improvement plan. * Add machine-id v3 tests Duplicates of the v1 tests, since those covered the cases that remain in v3, and we will remove v1 and its tests later. Also fix formatting of some python files. * DRY out machine ID paths into global constants
kmcgrady
pushed a commit
that referenced
this pull request
Jan 25, 2021
* switched react-katex package * lockfile updated * update test to corrected spelling * decapitalize KaTex * Fix slider UX (#2596) * Fix slider UX * Add snapshot * Revert "Deploy button front (#2552)" (#2599) * Revert "Deploy button front (#2552)" This reverts commit 0f66b6e. * Fix merge (erm... revert) conflict. * Revert "Deploy button py (#2535)" This reverts commit 0bbc7aa. Co-authored-by: karrie <karrie@streamlit.io> * Remove extra period from sentence (#2601) * Have st.number_input warn user of mismatched type and format string (#2604) * Add %u to list of valid number_input formatters * Have number_input warn user of mismatched type and format string * Use more modern f-string syntax instead of .format() * Feature/sudoless metrics (#2605) * Add and use sudoless machine id getter for metrics Step 2 of the metrics user ID improvement plan. * Add machine-id v3 tests Duplicates of the v1 tests, since those covered the cases that remain in v3, and we will remove v1 and its tests later. Also fix formatting of some python files. * DRY out machine ID paths into global constants * Increase side padding to 5rem when app is in wide mode (#2613) * Increase side padding to 5rem when app is in wide mode * Upload Cypress snapshot * Rerender Maybe components when they're first disabled (#2617) \#2395 ended up being caused by this since we don't rerender placeholder components created by `st.empty()` when react props/state change as a performance optimization, but we need to do so when replacing an existing component with an empty one to get rid of what's currently drawn on screen. Closes #2395 Co-authored-by: karrie <karrie@streamlit.io> Co-authored-by: Thiago Teixeira <thiago@streamlit.io> Co-authored-by: Randy Zwitch <randy@streamlit.io> Co-authored-by: Vincent Donato <vincent.rdonato@gmail.com> Co-authored-by: Amanda Walker <amanda@amandawalker.io> Co-authored-by: Austin Chen <akrolsmir@gmail.com> Co-authored-by: Vincent Donato <vincent@streamlit.io>
|
|
This PR is merged, but it doesn't actually solve the sudo problem. It is the first step in solving it, though! With this PR, we now compute 3 IDs, one of which depends on sudo. We want to get rid of 2 of these IDs (including the sudo one), but first need to collect a few months of data with all 3 IDs so we can understand how each of them impact our metrics. My guess is this will happen in the next 3 months or so. |
|
Is this sudoless working now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1584 is what prompted this, but will not be resolved until we remove the v1 ID in a few months. This PR is a stepping stone towards that.
Description: