Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.niconicochannelplus: add support for "nicochannel.jp" #4923

Closed
wants to merge 18 commits into from
Closed

plugins.niconicochannelplus: add support for "nicochannel.jp" #4923

wants to merge 18 commits into from

Commits on Nov 6, 2022

  1. plugins.niconicochannelplus: add VoD support for "nicochannel.jp"

    For VoD on "Niconico Channel Plus" (Japanese: ニコニコチャンネルプラス).
    https://portal.nicochannel.jp/
    
    Thanks to the following people who provided useful information:
    
    - lokilin, raised a request in issue 2537 of yt-dlp/yt-dlp;
    - 雷兰濑 (railannad), raised a request in issue 4366;
    - Trung0246, analyzed HTTP data in issue 4366;
    - Lesmiscore, made cross-reference between the above two issues.
    pzhlkj6612 committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    d641860 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7e1629 View commit details
    Browse the repository at this point in the history
  3. plugins.niconicochannelplus: improve the code based on code review

    - Store all URLs as class members for better human-reading.
    - Directly use the "HTTPSession" object which is from the Streamlink
      session instead of passing it from outside.
    - Use validation schemas instead of "json.loads" and "__getitem__" ([])
      for better data decoding, JSON validation and exception handling.
    - Directly return the result from "HLSStream.parse_variant_playlist"
      since the plugin does not modify the dictionary of streams.
    pzhlkj6612 committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    4d132c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. plugins.niconicochannelplus: only output title in debug level

    Both ID and channel name are in the URL, so no need to output them.
    pzhlkj6612 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    3d415c2 View commit details
    Browse the repository at this point in the history
  2. plugins.niconicochannelplus: remove unneeded metadata

    It's not informative.
    pzhlkj6612 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    c9654cc View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Configuration menu
    Copy the full SHA
    464eac5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41125d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    16bc033 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    31078e0 View commit details
    Browse the repository at this point in the history
  5. plugins.niconicochannelplus: don't output the title

    Titles are easy to find in the webpage.
    pzhlkj6612 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    711485b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    55673f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. plugins.niconicochannelplus: dots (.) are allowed in channel names

    That channel name is "kanase.ito".
    pzhlkj6612 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    e05e80c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    51a9223 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f75580d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. plugins.niconicochannelplus: DVR works if both "allow_dvr_flg" and "c…

    …onvert_to_vod_flg" are True
    
    The name of those fields is confusing.
    pzhlkj6612 committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    263e29a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f85eedb View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Configuration menu
    Copy the full SHA
    9661f97 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Configuration menu
    Copy the full SHA
    c91c19e View commit details
    Browse the repository at this point in the history