Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/arbitrary mpv options #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Feature/arbitrary mpv options #12

wants to merge 4 commits into from

Conversation

zohar-yzgiaev
Copy link
Contributor

Add arbitrary mpv options, see #2
While working on this and inspecting the mpv options, I tuckled in the 'http-proxy' flag which seems useful. @yuvadm should I add it to this PR?

yuvadm
yuvadm requested changes Oct 22, 2019
View reviewed changes
Copy link
Member

@yuvadm yuvadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we need to support arbitrary options, not just the ones I gave as examples. Probably the challenge here is to support de-serialization of arbitrary TOML. Perhaps we need to replace the Query struct with some dynamic HashMap of sorts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvadm yuvadm yuvadm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zohar-yzgiaev @yuvadm