Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr/useWindowSize callback #958

Closed
wants to merge 1 commit into from
Closed

pr/useWindowSize callback #958

wants to merge 1 commit into from

Conversation

morgsmccauley
Copy link

@morgsmccauley morgsmccauley commented Feb 10, 2020 •
edited

Description

Resolves #915

Still trying to wrap my head round requestAnimationFrame so let me know if this PR is fine. Can update docs if all is well :)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@morgsmccauley morgsmccauley changed the title pr/use window size callback pr/useWindowSize callback Feb 10, 2020
streamich
streamich reviewed Feb 15, 2020
View reviewed changes
src/useWindowSize.ts Outdated Show resolved Hide resolved
@streamich streamich changed the base branch from master to v14.0 February 15, 2020 10:24
@streamich
Copy link
Owner

I've switched base branch of this PR to v14.0 as this might be a substantial change in behaviour for some users.

@streamich streamich changed the base branch from v14.0 to master May 16, 2020 13:59
@morgsmccauley
Copy link
Author

Happy to re-open if you still think there is need 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamich streamich Awaiting requested review from streamich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useWindowSize callback
2 participants
@morgsmccauley @streamich