Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useLatestRef() and useLayoutLatestRef() #2509

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pastelmind
Copy link

Description

This PR adds two hooks useLatestRef() and useLayoutLatestRef() as described in #2328 (comment). They are similar to useLatest(), but avoid updating the ref directly during render, which is deemed unsafe by the React team..

This PR also marks useLatest() as @deprecated and recommend useLatestRef() as an alternative.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@nmoinvaz
Copy link

Nice PR!

@nathggns
Copy link

Really hope this is merged. useLatest is not safe.

@hengkx
Copy link

hengkx commented Apr 4, 2024

Is there any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants