Follow up to #61 #62
Merged
Follow up to #61 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [`CStr::from_bytes_with_nul_unchecked()`] is only `const` since rustc 1.59.0. Just don't use it `const`. * Moving the `static mut` variable into a getter function makes it more obvious that it cannot be changed after the initial assignment. [`CStr::from_bytes_with_nul_unchecked()`]: https://doc.rust-lang.org/1.64.0/std/ffi/struct.CStr.html#method.from_bytes_with_nul_unchecked
Merged
|
Looks good to me, so I merged this. Do you think it is worth a new release? |
|
Thank you! I'd say yes, because I might have broken the workflow of some Android developer who compiles the code on Debian old-stable for whatever reason. But I think we can wait a few hours if there are more comments in here or #61. I'll wait until midnight CEST, and do the release then, so the date in the changelog is still correct. :) |
|
Published as 0.1.50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CStr::from_bytes_with_nul_unchecked()is onlyconstsince rustc 1.59.0. Just don't use itconst.static mutvariable into a getter function makes it more obvious that it cannot be changed after the initial assignment.