Update to android_system_properties v0.1.5 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new release makes `AndroidSystemProperties` send + sync, so the initialization can be cached. This makes the stress test execute in ```text 0m00.61s real 0m04.00s user 0m00.02s system ``` Before it was ```text 1m37.25s real 1m06.81s user 0m57.95s system ``` I.e. it's now 9786 % faster. :)
Kijewski
force-pushed
the
pr-android_system_properties-0_1_5
branch
from
37859f7
to
5c5badb
Compare
|
I don't think we should cache results from the OS, as this would prevent getting an updated time zone in a long running process. With mobile OSes like Android in particular I guess this is an important issue. If better performance is needed, the user can cache themselves. |
|
This does not cache the result, only the "getter". We do the same already in the windows implementation. The getter is still called in every invocation. |
|
Thanks for the clarification. Yes, now that my coffee has kicked in, I see that, too. This looks good, so I merged it and published as 0.1.47. |
lopopolo
reviewed
Aug 30, 2022
|
Sorry I should have clarified with my review. My comments are only nits. Otherwise looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new release makes
AndroidSystemPropertiessend + sync, so theinitialization can be cached. This makes the stress test execute in
Before it was
I.e. it's now 9786 % faster. :)