Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential use after free in MacOS / iOS impl #54

Merged
merged 3 commits into from Aug 16, 2022
Merged

Fix potential use after free in MacOS / iOS impl #54

merged 3 commits into from Aug 16, 2022

Commits on Aug 16, 2022

  1. Fix potential use after free in MacOS / iOS impl 

    Per Ryan Lopopolo's review:

> This bit makes me a bit scared with the `Dropping` type and the `CStr`
  being dropped while a borrowed `&str` is taken from name. Is the
  `.map(|name| name.to_owned())` a use after free?
>
> To be sure, I'd probably restructure all of these combinators to use
  short circuit return to make sure the `Dropping` and `CStr` wrappers
  are dropped in the right order.

<strawlab#50 (comment)>
    @Kijewski
    Kijewski committed Aug 16, 2022
    Copy the full SHA
    0819f92 View commit details
    Browse the repository at this point in the history

  2. Allow non UTF-8 time zones 

    Though it is unlikely that the time zone is stored in an encoding other
than UTF-8, it's not much work add to support for this edge case.
    @Kijewski
    Kijewski committed Aug 16, 2022
    Copy the full SHA
    6bdb9ed View commit details
    Browse the repository at this point in the history

  3. Increment patch version

    @Kijewski
    Kijewski committed Aug 16, 2022
    Copy the full SHA
    4331500 View commit details
    Browse the repository at this point in the history