Bump windows-core to 0.55
#132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the necessary binding changes for compatibility, provided by `windows-bindgen 0.53-0.54`. Generated code by `windows-bindgen` now also expects `TryInto` to be in scope via Rust's `prelude`, which is only the case in Rust edition `2021`.
Note that `windows 0.55` was not released, and any implementation in the wild depending on `windows` will get `windows-core 0.54` in their dependency tree for obvious compatibility reasons, and would get a duplicate if `iana-time-zone` decides to switch to o`windows-core 0.55` prematurely. This PR depends on strawlab#131 and can be updated and merged whenever there is a compelling reason to bump further. This requires a strange change to remove a "comment" from `bindings.txt`: Running `api_gen/target/debug/api_gen` Error: Error { message: "unused filters\n Dependencies\n above\n the\n of\n #", path: "", span: None }
MarijnS95
force-pushed
the
windows-core-0.55
branch
from
91c14b0
to
59246f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that
windows 0.55was not released, and any implementation in the wild depending onwindowswill getwindows-core 0.54in their dependency tree for obvious compatibility reasons, and would get a duplicate ifiana-time-zonedecides to switch to owindows-core 0.55prematurely. This PR depends on #131 and can be updated and merged whenever there is a compelling reason to bump further.This requires a strange change to remove a "comment" from
bindings.txt: