Update windows-core requirement from >=0.50, <=0.52 to >=0.50, <=0.53 #128
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [windows-core](https://github.com/microsoft/windows-rs) to permit the latest version. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](microsoft/windows-rs@0.50.0...0.53.0) --- updated-dependencies: - dependency-name: windows-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
the
dependencies
astraw
changed the title
|
@MarijnS95 you wrote most of the current windows implementation. Would you be able to check what is required to update to windows-core 0.53? |
|
@astraw looks like the files need a regen. I'm still out of the country for little over a week, before I can take a proper look. |
|
@MarijnS95 thanks for the quick reply. It would be great if you can take a look when you are back. |
|
A newer version of windows-core exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
Alas, windows-core 0.54 is not backward compatible to 0.52. And the generated code in Windows.rs uses edition 2021 features. So, we can either
I don't like the 1st option, because we wouldn't benefit from any upgrades, security fixes, etc. the windows people implement. I don't like the 2nd option, because it makes us less trustworthy if we ship a metric ton of generated code that cannot be easily diff'd. I would find option 3 acceptable. It's been over two years since rustc 1.56 was released on 2021-10-21. But I like option 4 the best, actually. Windows.rs has 10x the size of the other code combined. What do you think? |
|
@Kijewski your thoughts sound reasonable and I'd support your approach. I rarely develop on Windows and so it would be great if you and @MarijnS95 could shepherd this through. |
Updates the requirements on windows-core to permit the latest version.
Release notes
Sourced from windows-core's releases.
... (truncated)
Commits
b1fadffRelease 0.53.0 (readme)2d06ee6Release 0.53.0 (#2854)352bd45Ability to read branch information from URL (#2867)3396244Add feature search links (#2865)9e03c57Add new feature search web app (#2864)65b8adaString trait refactoring (#2863)075c3c1Simpler package layout for natvis files (#2862)426865aAddNTSTATUSmessage formatting support to thewindows-resultcrate (#2861)6682202ImproveNTSTATUSconstant literal generation (#2860)1c55102Generate features index for windows and sys crates (#2859)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)