Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-core requirement from >=0.50, <=0.51 to >=0.50, <=0.52 #123

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 17, 2023

Updates the requirements on windows-core to permit the latest version.

Release notes

Sourced from windows-core's releases.

0.51.1

This is mainly for publishing an update of the windows-bindgen crate but also fixes a few minor readme and version issues to avoid confusion.

  • The windows and windows-core crates are updated to 0.51.1 to update the readme but are otherwise unchanged.
  • The windows-targets crate and arch-specific crates are updated to 0.48.3 to update the readme and bring the lib file names in line with the crate version.

Those are all semver-compatible updates.

  • The windows-bindgen crate is updated to 0.51.1 and includes the new riddle-based metadata processing capabilities and is compatible with the windows and windows-core crates.
  • The windows-metadata crate is updated to 0.51.1 and includes many refinements but is largely for internal use.

Those are major breaking changes.

The windows-sys crate will not be updated at this time.

What's Changed

Full Changelog: microsoft/windows-rs@0.51.0...0.51.1

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [windows-core](https://github.com/microsoft/windows-rs) to permit the latest version.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](microsoft/windows-rs@0.50.0...0.51.1)

---
updated-dependencies:
- dependency-name: windows-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 17, 2023
@astraw
Copy link
Member

astraw commented Oct 17, 2023

I don't understand this. It updates dependencies to allow windows-core 0.52, but that's not released as of now. The most recent release of windows-core is 0.51.1, which is allowed currently.

@astraw astraw closed this Oct 17, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 17, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/windows-core-gte-0.50-and-lte-0.52 branch October 17, 2023 08:03
@Kijewski
Copy link
Collaborator

I am not sure how the expression <=0.51 is parsed by cargo and dependabot. Is it the same as <=0.51.* or <=0.51.0? From experience I can tell that dependabot does not always understand version ranges for python's requirements.txt.

Maybe we should replace the expression with < 0.52 to be sure? That should be understood the same and correctly by both dependabot and cargo.

@astraw
Copy link
Member

astraw commented Oct 17, 2023

I checked and our CI is building with windows-core 0.51.1 so Cargo parses it as <=0.51.*. Given this PR, yes, I guess dependabot uses <=0.51.0.

Maybe we should replace the expression with < 0.52 to be sure? That should be understood the same and correctly by both dependabot and cargo.

I'm not sure - will e.g. alpha versions of 0.52 be included by Cargo? We don't want that. I'm happy to just keep things as they are and close PRs from dependabot affected by this.

@Kijewski
Copy link
Collaborator

Thanks for verifying! Then cargo is consistent in this regard.

Cargo never selects a pre-release. You always have to type the exact version to get an alpha version, i.e. 0.1.0-alpha.0 and 0.1.0-alpha.1 are not version compatible with one another in either direction, or with any other version.

But given that dependabot said "OK, I won't notify you again about this release, but will get in touch when a new version is available", I guess we can keep the current version requirement. If dependabot opens a PR for windows-core 0.51.2, we can close it again, and for 0.52.0 we can update it requirement manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants