-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows requirement from 0.47.0 to 0.48.0 #102
Conversation
Updates the requirements on [windows](https://github.com/microsoft/windows-rs) to permit the latest version. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](microsoft/windows-rs@0.47.0...0.48.0) --- updated-dependencies: - dependency-name: windows dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
The new @kennykerr @Kijewski @djc Can I ask for your opinions if we should try to use this new |
I was one of the people pushing upstream for this approach, so yes, I think using windows-bindgen might help (a) reduce the amount of version churn you have to manage in this project's dependencies and (b) help reduce the download size of your dependency bundle, since Cargo features are selected after download -- so depending on windows/windows-sys will require downstream users to download all of it before discarding most of it via Cargo features. |
And so I vouch for using |
I recommend going with 0.48 for the time being as I am still working on standalone code generation support for COM and WinRT APIs. |
Released as 0.1.56. Depending on a yanked release is bad. We can switch to |
Updates the requirements on windows to permit the latest version.
Release notes
Sourced from windows's releases.
Commits
4069441
Improve target version reliability (#2412)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)