Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows requirement from 0.47.0 to 0.48.0 #102

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 3, 2023

Updates the requirements on windows to permit the latest version.

Release notes

Sourced from windows's releases.

0.48.0

This release includes an update to all crates to address a target version reliability issue. This issue is detailed here: microsoft/windows-rs#2410

What's Changed

Full Changelog: microsoft/windows-rs@0.47.0...0.48.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [windows](https://github.com/microsoft/windows-rs) to permit the latest version.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](microsoft/windows-rs@0.47.0...0.48.0)

---
updated-dependencies:
- dependency-name: windows
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 3, 2023
@astraw
Copy link
Member

astraw commented Apr 3, 2023

The new windows release includes some interesting changes, called windows-bindgen, as documented here microsoft/windows-rs#2399.

@kennykerr @Kijewski @djc Can I ask for your opinions if we should try to use this new windows-bindgen approach rather than simply updating the windows dependency? Should windows-bindgen in principle work for us already? We just need windows::Globalization::Calendar but I haven't followed windows-bindgen closely enough to know if it solves this case.

@djc
Copy link
Contributor

djc commented Apr 3, 2023

I was one of the people pushing upstream for this approach, so yes, I think using windows-bindgen might help (a) reduce the amount of version churn you have to manage in this project's dependencies and (b) help reduce the download size of your dependency bundle, since Cargo features are selected after download -- so depending on windows/windows-sys will require downstream users to download all of it before discarding most of it via Cargo features.

@MarijnS95
Copy link
Contributor

MarijnS95 commented Apr 3, 2023

And so windows 0.48 dropped, while 0.47 was yanked (details: microsoft/windows-rs#2412) making this bump extra important!

I vouch for using windows-bindgen directly too, as it should rid us of some of these version bumps caused by breaking generation/metadata changes alone, and will make for a much smaller crate to be downloaded. However, that's pending @kennykerr's splitting off builtin types to windows-core since iana-time-zone uses the windows crate for its COM API, hence cannot use windows-sys nor the minimal API currently emitted by windows-bindgen.

@kennykerr
Copy link

I recommend going with 0.48 for the time being as I am still working on standalone code generation support for COM and WinRT APIs.

@Kijewski Kijewski merged commit dbbe109 into main Apr 3, 2023
53 of 55 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/windows-0.48.0 branch April 3, 2023 15:26
@Kijewski
Copy link
Collaborator

Kijewski commented Apr 3, 2023

Released as 0.1.56. Depending on a yanked release is bad. We can switch to windows-bindgen when it's ready. For now, bumping the dependency version is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants