Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows requirement from 0.46.0 to 0.47.0 #101

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Update windows requirement from 0.46.0 to 0.47.0 #101

merged 1 commit into from
Mar 30, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 30, 2023

Updates the requirements on windows to permit the latest version.

Release notes

Sourced from windows's releases.

0.47.0

As a reminder, updates are only published by request (#2397; microsoft/win32metadata#1507). This release provides an update to the windows crate. It does not include an update to the windows-sys crate.

This update adds support for standalone code generation (#2396) as well as requested fixes to the Win32 metadata that prevented some APIs from being used.

What's Changed

Full Changelog: microsoft/windows-rs@0.46.0...0.47.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Update windows requirement from 0.46.0 to 0.47.0
6f1940d 
Updates the requirements on [windows](https://github.com/microsoft/windows-rs) to permit the latest version.
- [Release notes](https://github.com/microsoft/windows-rs/releases)
- [Commits](microsoft/windows-rs@0.46.0...0.47.0)

---
updated-dependencies:
- dependency-name: windows
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 30, 2023
@astraw astraw merged commit c3e162d into main Mar 30, 2023
@dependabot dependabot bot deleted the dependabot/cargo/windows-0.47.0 branch March 30, 2023 10:04
@Kijewski
Copy link
Collaborator

Maybe we should use version = ">= 0.46, < 0.48"? We actually don't care what exact version of the windows crate we are using, as long as it's know to be compatible. And this way cargo should be able to merge two windows dependencies in a project, when both depend on "intersecting version ranges", which reduces the amount of crates to download for the user, and a little faster compilation times.

@astraw
Copy link
Member

astraw commented Mar 30, 2023

Oh, that's an interesting idea. Unfortunately I just released with the windows 0.47 requirement. Do you know of any crates that do this - I would like to look at a "real" example.

Relatedly, I wonder how far windows is from a 1.x release. (I haven't been following this closely.)

@Kijewski
Copy link
Collaborator

Kijewski commented Mar 30, 2023 •
edited

I use it nate, but since I'm probably its only user, I wouldn't necessarily call it a "real" example. :D

I went through the first few pages of the most downloaded crates, and this feature is not used by anyone. Neither their dependencies, nor when they are the dependency. The only non-trivial > 1M download example I have found was nom-supreme, which can be used with nom [6.0.1; 8).

I guess in this case we shouldn't use it either, lest we find or produce a bug in this little used (and possibly known) feature.

@Kijewski
Copy link
Collaborator

I don't think that windows will be 1.* anytime soon. Their version bumps were breaking changes, and they had to fix some argument types, when things in Rust and C didn't fit together very well. It's too bad that windows is such a huge monolithic crate, so that even changes in totally unrelated subsystems affect effectively everyone.

@kennykerr
Copy link

Apologies for the breaking changes - I'm working on metadata (API) stabilization which should fix this issue in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astraw astraw astraw approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kijewski @astraw @kennykerr