fix(mypy): Fix issue with input and interface pydantic decorators

[thejaminator]

Resolves #1830

Description

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• [ x] I have added tests to cover my changes.
• [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[thejaminator]

i think we forgot to support the interface decorator, so i just added it

[codecov]

Codecov Report

Merging #1832 (5b4bd99) into main (f793f07) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1832   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files         143      143           
  Lines        5466     5467    +1     
  Branches     1001     1001           
=======================================
+ Hits         5365     5366    +1     
  Misses         50       50           
  Partials       51       51           

[botberry]

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

---

Fixes mypy type inference when using @strawberry.experimental.pydantic.input
and @strawberry.experimental.pydantic.interface decorators

---

Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to James Chua for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

[thejaminator]

technically you could just leave in partial(type, is_input=True) and put this in the IF TYPE_CHECKING block. Anyways i made it like this so that its less confusing when users introspect. they may not be familar to what IF TYPE_CHECKING

[patrick91]

Makes sense, do you think we can also add this? https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/object_type.py#L152-L153

this should make it work slightly better with pyright

[thejaminator]

Makes sense, do you think we can also add this? https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/object_type.py#L152-L153

this should make it work slightly better with pyright

does that work out of the box for the pydantic conversion? not familar with how that works but i think the init for the dataclass wouldn't work well because not all the fields are in the class getting decorated.

e.g.

class UserCreate(BaseModel):
    email: str


@strawberry.experimental.pydantic.input(model=UserCreate, all_fields=True)
class UserCreateInput:
    pass # the fields aren't here

if it doesn't and gives false positives i'll settle it in another issue

[patrick91]

Makes sense, do you think we can also add this? https://github.com/strawberry-graphql/strawberry/blob/main/strawberry/object_type.py#L152-L153
this should make it work slightly better with pyright

does that work out of the box for the pydantic conversion? not familar with how that works but i think the init for the dataclass wouldn't work well because not all the fields are in the class getting decorated.

e.g.

class UserCreate(BaseModel):
    email: str


@strawberry.experimental.pydantic.input(model=UserCreate, all_fields=True)
class UserCreateInput:
    pass # the fields aren't here

if it doesn't and gives false positives i'll settle it in another issue

it only works with fields that are defined, so yeah, let's do it in another issue :)