Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8413 - Immer dependancy #8420

Merged
merged 1 commit into from Oct 22, 2020
Merged

Fix #8413 - Immer dependancy #8420

merged 1 commit into from Oct 22, 2020

Conversation

derrickmehaffy
Copy link
Member

Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com

What does it do?

fixes #8413

Why is it needed?

Issue with upstream package causing a problem on windows, issue fixed upstream

Related issue(s)/PR(s)

#8413

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy added the issue: bug Issue reporting a bug label Oct 21, 2020
@derrickmehaffy derrickmehaffy requested a review from a team October 21, 2020 14:06
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #8420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8420   +/-   ##
=======================================
  Coverage   33.27%   33.27%           
=======================================
  Files        1220     1220           
  Lines       13625    13625           
  Branches     1357     1357           
=======================================
  Hits         4534     4534           
  Misses       8207     8207           
  Partials      884      884           
Flag Coverage Δ
#front 24.72% <ø> (ø)
#unit 54.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c684d...0b4a810. Read the comment docs.

@alexandrebodin alexandrebodin requested review from HichamELBSI and soupette and removed request for a team October 21, 2020 14:13
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrickmehaffy derrickmehaffy added this to the 3.2.5 milestone Oct 21, 2020
@derrickmehaffy
Copy link
Member Author

@alexandrebodin are the two failed tests from the update or is this just a bug with the new testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:admin Source is core/admin package
Projects
None yet
3 participants