add update-notifier #8363
Closed
add update-notifier #8363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Codecov Report
@@ Coverage Diff @@
## features/application-settings #8363 +/- ##
==============================================================
Coverage 33.67% 33.67%
==============================================================
Files 1243 1243
Lines 13711 13711
Branches 1362 1362
==============================================================
Hits 4617 4617
Misses 8204 8204
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
petersg83
commented
Oct 16, 2020
| const releaseLink = chalk.bold('https://github.com/strapi/strapi/releases'); | ||
| let message = ` | ||
| A new version of Strapi is available ${currentVersionLog} → ${newVersionLog} | ||
| Check out new releases at: ${releaseLink} |
There was a problem hiding this comment.
@derrickmehaffy
What do you think: Check out new releases at or Check out the new releases at ?
There was a problem hiding this comment.
Check out the new release(s) at
(Not sure if that needs to be plural or not)
|
Close it in favor of #8526 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual code has the following issue: yeoman/update-notifier#196
Waiting for answers on the issue to update the code accordingly.