-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci: improve install time iteration 2 #16638
Changes from all commits
4bc8311
4ed8f00
13d1e4f
aa576e5
47963ec
ead8b01
cb145dc
3b6b5ee
dd4cd53
1c35279
808619c
b3888fa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,11 +1,17 @@ | ||||||||||||||||||||||||||||||||||||||
nodeLinker: node-modules | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
enableGlobalCache: false | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
nmMode: hardlinks-local | ||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is not totally required. We'll see the ultimate choice made by upcoming yarn 4. But I'd say... keep it there explicitly (in yarn 3 it's the default). I'm open to remove this too (anyway the install action explcitly overrides it to 'hardlinks-local') |
||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
plugins: | ||||||||||||||||||||||||||||||||||||||
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs | ||||||||||||||||||||||||||||||||||||||
spec: '@yarnpkg/plugin-interactive-tools' | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
defaultSemverRangePrefix: '' | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
compressionLevel: 0 | ||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the zip isn't compressed. More work for action/cache restore / network / decompress (zstd detects when it can compress or not so... now the *.zip files will be compressable by action/cache -> slower but more compressed too) For the curious: My previous benchmarks +/- based on https://github.com/belgattitude/nextjs-monorepo-example Speed
Cache budget
More metrics in https://github.com/belgattitude/compare-package-managers |
||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
preferInteractive: true | ||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||
yarnPath: .yarn/releases/yarn-3.5.0.cjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some might wonder, why it's suddently needed. Cause afterall it's overridden in the install action.
Context:
PS: enableGlobalCache might be default in upcoming yarn version, so we align for the future as well)