Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update axios to 1.2.2 #15421

Merged
merged 1 commit into from Jan 16, 2023
Merged

Chore: Update axios to 1.2.2 #15421

merged 1 commit into from Jan 16, 2023

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Jan 12, 2023

What does it do?

Bumps axios to 1.2.2.

Why is it needed?

Axios 1.2.1 contains a bug which is fixed in 1.2.2.

Related issue(s)/PR(s)

@gu-stav gu-stav added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Jan 12, 2023
@gu-stav gu-stav added this to the 4.6.0 milestone Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 60.48% // Head: 60.48% // No change to project coverage 👍

Coverage data is based on head (8282fc1) compared to base (e3222fd).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15421   +/-   ##
=======================================
  Coverage   60.48%   60.48%           
=======================================
  Files        1353     1353           
  Lines       33202    33202           
  Branches     6353     6353           
=======================================
  Hits        20081    20081           
  Misses      11280    11280           
  Partials     1841     1841           
Flag Coverage Δ
back 50.37% <71.42%> (ø)
front 65.03% <ø> (ø)
unit_back 50.37% <71.42%> (ø)
unit_front 65.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/core/strapi/lib/core-api/service/single-type.js 88.00% <71.42%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gu-stav gu-stav merged commit 1898626 into main Jan 16, 2023
@gu-stav gu-stav deleted the chore/axios-1-2-2 branch January 16, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axios 1.2.1 in Strapi 4.5.5 breaking things
3 participants