Fe/main build #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed yarn.lock and package-lock.json
derrickmehaffy
requested changes
Apr 22, 2024
copytypes.js
Outdated
| // Adjust these paths as per your project structure | ||
| const files = [ | ||
| { | ||
| src: path.join(__dirname, "./backend/types/generated/contentTypes.d.ts"), |
There was a problem hiding this comment.
We should probably use an os agnostic package, while none of us use windows there might be some external users or fork/clone this.
There was a problem hiding this comment.
Resolved made it agnostic.
|
Moved to React and Server components instead of, remix due to Remix been moved to react router. |
derrickmehaffy
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see: Notion Doc for commands that are added to
package.jsonLet me know if you want any changes to it.
copytypes.jsTo use the built-inyarn strapi ts:generate-typescommand. It will copy it into the frontend