This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move config parsing to use context #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Dec 29, 2021
| upgradeclient "github.com/cosmos/cosmos-sdk/x/upgrade/client" | ||
| ) | ||
|
|
||
| var ModuleBasics = []module.AppModuleBasic{ |
There was a problem hiding this comment.
is this for encodings or decoding txs?
tac0turtle
reviewed
Dec 29, 2021
| Debug: debug, | ||
| Timeout: "20s", | ||
| OutputFormat: "json", | ||
| BroadcastMode: "block", |
There was a problem hiding this comment.
should avoid using block, this was meant for testing that ended up bleeding into prod.
There was a problem hiding this comment.
I guess I should add a mempool query that sees if we have a TX in the mempool before trying to submit another one
|
closing this in favor of other work. Come back to this once cobra merges spf13/cobra#1551 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will move the config parsing to stuffing the chains into the
context.Contextwhere they will be consumed in the cli functions