Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native: Patch preview-web and refs to support RN #19975

Merged
merged 1 commit into from Nov 27, 2022

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Nov 26, 2022

Issue:

What I did

These are some changes discussed previously with @tmeasday @ndelangen and @shilman.

Just hoping I can help move things forward by making this PR.

I applied some small changes in order to enable the v6 of react native storybook. These are:

  • making preview and url store optional parameters on the preview web constructor which fixes a crash on react native
  • in refs passing a default value when source is not defined in order to bypass a crash in react-native-server

These changes along side this pr on telejson are the main blockers for v6 on react native.

storybookjs/telejson#84

Heres the related react-native-server PR
storybookjs/react-native#393

I'm not sure if there are further implications of these changes and I'm very happy to adjust these changes if they don't make sense.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@dannyhw dannyhw changed the base branch from next to main-prerelease November 26, 2022 13:12
@dannyhw dannyhw marked this pull request as ready for review November 26, 2022 13:22
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. @tmeasday @ndelangen ?

@ndelangen
Copy link
Member

Looks great!

@shilman shilman changed the title fix: patch preview web and refs to not crash react native storybook React Native: Patch preview-web and refs to support RN 6.x Nov 27, 2022
@shilman shilman changed the title React Native: Patch preview-web and refs to support RN 6.x React Native: Patch preview-web and refs to support RN Nov 27, 2022
@shilman shilman merged commit e5375c6 into storybookjs:main-prerelease Nov 27, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants