Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #19623 (overriding WebView/UrlStore) to 6.5 #19904

Closed
tmeasday opened this issue Nov 21, 2022 · 2 comments
Closed

Backport #19623 (overriding WebView/UrlStore) to 6.5 #19904

tmeasday opened this issue Nov 21, 2022 · 2 comments

Comments

@tmeasday
Copy link
Member

tmeasday commented Nov 21, 2022

Is your feature request related to a problem? Please describe

React Native wants to be able to define a non-web version of the view+store without needing to monkey patch and polyfill.

We have a solution in #19623 but we need to backport it to 6.5

Describe the solution you'd like

As #19623 but leaving out the complex typing changes.

@yannbf
Copy link
Member

yannbf commented Nov 30, 2022

Quick reminder to also change code in the instrumenter if you're backporting this to 6.5, else addon-interactions will break as it refers to urlStore to get the story ids.

@tmeasday
Copy link
Member Author

tmeasday commented Dec 1, 2022

This got sorted out in #19975 -- the change was really simple in 6.x so the above won't be an issue. Thanks for highlighting @yannbf

@tmeasday tmeasday closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants