(Theming) Replace references to themes.normal with themes.light
#17034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dad261a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
added
documentation
patch:yes
|
HI all - please let me know if there is anything else that needs to be updated for this PR. Now that the holidays are past I've got more time to attend to any additional items that need an update here. Thanks! |
|
@MichaelArestad putting this on your radar so that we don't lose track of it. If changes are required to the docs I'm more than glad to make them. |
MichaelArestad
approved these changes
Jun 22, 2022
MichaelArestad
added
maintenance
ndelangen
approved these changes
Jun 30, 2022
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jul 26, 2022
…mal-theme-to-light-theme (Theming) Replace references to `themes.normal` with `themes.light`
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16937
What I did
Replaced all non-breaking references to
themes.normalwiththemes.light. Changes made to addons and examples. There were no tests for this functionality and, given the small scale of the updates, I didn't see a need to add a new test. I did, however, manually verify that usingthemes.normalstill works as a base theme and as a theme selection in.storybook/manager.js.How to test
If your answer is yes to any of these, please make sure to include it in your PR.