Skip to content

Commit

Permalink
Merge pull request #17034 from richorrichard/16937-theming-change-nor…
Browse files Browse the repository at this point in the history
…mal-theme-to-light-theme

(Theming) Replace references to `themes.normal` with `themes.light`
  • Loading branch information
ndelangen authored and shilman committed Jul 26, 2022
1 parent 215294e commit 3e8ceba
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 21 deletions.
6 changes: 3 additions & 3 deletions addons/a11y/src/components/A11yContext.tsx
Expand Up @@ -22,9 +22,9 @@ interface A11yContextStore {
}

const colorsByType = [
convert(themes.normal).color.negative, // VIOLATION,
convert(themes.normal).color.positive, // PASS,
convert(themes.normal).color.warning, // INCOMPLETION,
convert(themes.light).color.negative, // VIOLATION,
convert(themes.light).color.positive, // PASS,
convert(themes.light).color.warning, // INCOMPLETION,
];

export const A11yContext = React.createContext<A11yContextStore>({
Expand Down
18 changes: 9 additions & 9 deletions addons/interactions/src/components/List.tsx
Expand Up @@ -12,26 +12,26 @@ const ListWrapper = styled.ul({
const Wrapper = styled.div({
display: 'flex',
width: '100%',
borderBottom: `1px solid ${convert(themes.normal).appBorderColor}`,
borderBottom: `1px solid ${convert(themes.light).appBorderColor}`,
'&:hover': {
background: convert(themes.normal).background.hoverable,
background: convert(themes.light).background.hoverable,
},
});

const Icon = styled(Icons)<IconsProps>({
height: 10,
width: 10,
minWidth: 10,
color: convert(themes.normal).color.mediumdark,
color: convert(themes.light).color.mediumdark,
marginRight: 10,
transition: 'transform 0.1s ease-in-out',
alignSelf: 'center',
display: 'inline-flex',
});

const HeaderBar = styled.div({
padding: convert(themes.normal).layoutMargin,
paddingLeft: convert(themes.normal).layoutMargin - 3,
padding: convert(themes.light).layoutMargin,
paddingLeft: convert(themes.light).layoutMargin - 3,
background: 'none',
color: 'inherit',
textAlign: 'left',
Expand All @@ -41,13 +41,13 @@ const HeaderBar = styled.div({

'&:focus': {
outline: '0 none',
borderLeft: `3px solid ${convert(themes.normal).color.secondary}`,
borderLeft: `3px solid ${convert(themes.light).color.secondary}`,
},
});

const Description = styled.div({
padding: convert(themes.normal).layoutMargin,
marginBottom: convert(themes.normal).layoutMargin,
padding: convert(themes.light).layoutMargin,
marginBottom: convert(themes.light).layoutMargin,
fontStyle: 'italic',
});

Expand All @@ -69,7 +69,7 @@ export const ListItem: React.FC<ListItemProps> = ({ item }) => {
<HeaderBar onClick={() => onToggle(!open)} role="button">
<Icon
icon="chevrondown"
color={convert(themes.normal).appBorderColor}
color={convert(themes.light).appBorderColor}
style={{
transform: `rotate(${open ? 0 : -90}deg)`,
}}
Expand Down
10 changes: 5 additions & 5 deletions addons/jest/src/components/Panel.tsx
Expand Up @@ -99,13 +99,13 @@ const getColorByType = (type: string) => {
// using switch to allow for new types to be added
switch (type) {
case StatusTypes.PASSED_TYPE:
return convert(themes.normal).color.positive;
return convert(themes.light).color.positive;
case StatusTypes.FAILED_TYPE:
return convert(themes.normal).color.negative;
return convert(themes.light).color.negative;
case StatusTypes.PENDING_TYPE:
return convert(themes.normal).color.warning;
return convert(themes.light).color.warning;
case StatusTypes.TODO_TYPE:
return convert(themes.normal).color.purple;
return convert(themes.light).color.purple;
default:
return null;
}
Expand Down Expand Up @@ -154,7 +154,7 @@ const Content = styled(({ tests, className }: ContentProps) => (
</SuiteHead>
<TabsState
initial="failing-tests"
backgroundColor={convert(themes.normal).background.hoverable}
backgroundColor={convert(themes.light).background.hoverable}
>
<div
id="failing-tests"
Expand Down
2 changes: 1 addition & 1 deletion addons/jest/src/components/Result.tsx
Expand Up @@ -67,7 +67,7 @@ export function Result(props: ResultProps) {
<Icon
icon="chevrondown"
size={10}
color={convert(themes.normal).color.mediumdark}
color={convert(themes.light).color.mediumdark}
style={{
transform: `rotate(${isOpen ? 0 : -90}deg)`,
}}
Expand Down
Expand Up @@ -15,9 +15,9 @@ export default {
decorators: [(storyFn) => <div style={{ padding: 10 }}>{storyFn()}</div>],
};

const PassesHighlight = styled.div(highlightObject(convert(themes.normal).color.positive));
const IncompleteHighlight = styled.div(highlightObject(convert(themes.normal).color.warning));
const ViolationsHighlight = styled.div(highlightObject(convert(themes.normal).color.negative));
const PassesHighlight = styled.div(highlightObject(convert(themes.light).color.positive));
const IncompleteHighlight = styled.div(highlightObject(convert(themes.light).color.warning));
const ViolationsHighlight = styled.div(highlightObject(convert(themes.light).color.negative));

export const Passes = () => <PassesHighlight>{text}</PassesHighlight>;
export const Incomplete = () => <IncompleteHighlight>{text}</IncompleteHighlight>;
Expand Down

0 comments on commit 3e8ceba

Please sign in to comment.