This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Fix path for export WebProjectAnnotations #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the library to test stories in a TS project, the build breaks because the import path of type WebProjectAnnotations was incorrect, with this change the problem is solved.
|
A fix has already been merged: storybookjs/storybook#19048 |
I believe you have taken a slightly longer route, exporting from one library the module from another, but that solves it just the same, which is fine. Is your fix already available for use in some version? |
|
@TadeuA Confirmed fixed in 6.5.11, and the stack is at 6.5.12 now. |
|
Hey @TadeuA thanks a lot for your PR! Sorry for the late reply, but this seems to be no longer needed as there was a fix in Storybook 6.5.11. I'll be closing this PR, thanks once again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18531
storybookjs/storybook#18531
What Changed
When using the library to test stories in a TS project, the build breaks because the import path of type WebProjectAnnotations was incorrect, with this change the problem is solved.
Checklist
Check the ones applicable to your change:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor