Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Update storybook pkg #115

Closed
wants to merge 4 commits into from
Closed

Conversation

sakit0
Copy link

@sakit0 sakit0 commented Aug 25, 2022

Issue: #106

What Changed

  • Update Storybooks pkg
  • WebProjectAnnotations @storybook/preview-web to @storybook/store.
  • skipLibCheck to false

Checklist

Check the ones applicable to your change:

  • Tests are updated
  • Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@sakit0
Copy link
Author

sakit0 commented Aug 25, 2022

The build now succeeds.
However, if skipLibCheck : false , the build fails.
I think it would be better to set skipLibCheck : false.

This error occurs.

The inferred type of 'composeStory' cannot be named without a reference to '@storybook/client-api/node_modules/@storybook/csf'. This is likely not portable. A type annotation is necessary.

@shilman shilman added dependencies Update one or more dependencies version major Increment the major version when merged labels Aug 29, 2022
@clintandrewhall
Copy link

FYI: storybookjs/storybook#19048 is also pending, which resolves it for shorter-term patch release.

@sakit0
Copy link
Author

sakit0 commented Aug 30, 2022

@clintandrewhall
thank you!
I will fix it to use when it is released.

@sakit0
Copy link
Author

sakit0 commented Aug 31, 2022

skipLibCheck was set to false.
This fixed the error.
#115 (comment)

The version of @storybook/csf was out of sync with @storybook/client-api and @storybook/store's dependencies on @storybook/csf, so we aligned them.

@yannbf
Copy link
Member

yannbf commented Jan 11, 2023

Hey @sakit0, thank you so much for your contribution! Given that Storybook 7.0 has reached beta, in the efforts of supporting it, I released 2.0.0-next.0 which supports Storybook 7 and does most changes you did in this PR, but in the new structure for Storybook 7.0.

Given that this PR is a breaking change for users that use 1.x.x, and we now have a 2.0.0 version that supports Storybook 7.0, and getting this released is going to be a lot of effort, so I'd rather have users migrate their Storybook to 7.0 instead, and they won't have any issues with testing-react v2.

I hope you understand, and I'll be closing this PR. Thank you so much once again for your time!

@yannbf yannbf closed this Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Update one or more dependencies version major Increment the major version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants