CI: Fix GitHub unit test workflow #9971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonspalmer
commented
Feb 27, 2020
| @@ -5,22 +5,26 @@ on: [push] | |||
| jobs: | |||
| build: | |||
|
|
|||
| name: Test on node ${{ matrix.node_version }} and ${{ matrix.os }} | |||
There was a problem hiding this comment.
The previous version failed because we weren't using the matrix but trying to reference it in the name.
jonspalmer
force-pushed
the
fix_github_unit_tests
branch
from
52c025a
to
1c4c365
Compare
jonspalmer
force-pushed
the
fix_github_unit_tests
branch
from
1c4c365
to
3363102
Compare
shilman
added
maintenance
jonspalmer
commented
Feb 27, 2020
| @@ -17,7 +17,7 @@ jobs: | |||
| - uses: actions/setup-node@v1 | |||
| with: | |||
| node-version: '10.x' | |||
| - uses: actions/checkout@v1 | |||
| - uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
v2 is faster. Looks like its 2s vs 25s to checkout the repo. Small things add up :)
ndelangen
approved these changes
Feb 27, 2020
jonspalmer
force-pushed
the
fix_github_unit_tests
branch
from
44ae04d
to
9f525d4
Compare
shilman
changed the title
shilman
changed the title
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Mar 14, 2020
CI: Fix GitHub unit test workflow
shilman
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the GitHub unit test workflow and added tests for Node 12