Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix manager assets to be routed in express #9646

Merged
merged 6 commits into from
Feb 6, 2020
Merged

Core: Fix manager assets to be routed in express #9646

merged 6 commits into from
Feb 6, 2020

Conversation

ndelangen
Copy link
Member

Issue: #9443

What I did

I changed the way the manager webpack process starts/watches. By doing this it's possible to add all the webpack routes to express.

This was already the way preview works.

@ndelangen
ADD all entrypoints of manager to express routes (prefer manager entr…
0177ee7 
…ies over preview)

namechange the webpackDevMiddleWare to preview... for clarity
@ndelangen
ADD example usage
42b413d
@ndelangen
Because all assets generated by webpack are now added to the routes a…
5dfa10c 
…utomatically, we no longer need this.
@ndelangen ndelangen self-assigned this Jan 27, 2020
@vercel
Copy link

vercel bot commented Jan 27, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

shilman
shilman approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! but what's up with the deepscan issues @ndelangen ?

@ndelangen
Copy link
Member Author

Should be fixed now @shilman

@shilman shilman added this to the 6.0.0 milestone Feb 6, 2020
@shilman shilman changed the title Fix/9443 - assets in manager routed in express Core: Fix assets in manager routed in express Feb 6, 2020
@shilman shilman changed the title Core: Fix assets in manager routed in express Core: Fix manager assets to be routed in express Feb 6, 2020
@shilman shilman merged commit 951283b into next Feb 6, 2020
@shilman shilman deleted the fix/9443-assets-in-manager branch February 6, 2020 03:28
@shilman shilman mentioned this pull request Feb 7, 2020
Closed
@shilman
Copy link
Member

shilman commented Mar 5, 2020

@ndelangen do you think it's safe to patch this back to master?

@ndelangen
Copy link
Member Author

Yes, I think this is safe to port to 5.3 really.

@kylepeeler
Copy link

Please port back to 5.3!

@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 30, 2020
shilman added a commit that referenced this pull request Mar 31, 2020
@shilman
Merge pull request #9646 from storybookjs/fix/9443-assets-in-manager
b633e48 
Core: Fix manager assets to be routed in express
@snyk-bot snyk-bot mentioned this pull request Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndelangen @shilman @kylepeeler