Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-viewports: Fix missing TypeScript types #8848

Merged
merged 2 commits into from Nov 15, 2019
Merged

Addon-viewports: Fix missing TypeScript types #8848

merged 2 commits into from Nov 15, 2019

Conversation

rbardini
Copy link
Contributor

Issue: #8611

What I did

  • Migrate preview.js to TypeScript and move it to src
  • Update main field and add types field to package.json

@vercel
Copy link

vercel bot commented Nov 15, 2019 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/k85ytmr9y
🌍 Preview: https://monorepo-git-fork-rbardini-fix-addon-viewport-types.storybook.now.sh

@shilman shilman added maintenance User-facing maintenance tasks bug and removed maintenance User-facing maintenance tasks labels Nov 15, 2019
@shilman shilman changed the title Fix missing addon viewport TypeScript types Addon-viewports: Fix missing TypeScript types Nov 15, 2019
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 15, 2019
shilman
shilman approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added this to the 5.2.x milestone Nov 15, 2019
@shilman shilman merged commit aaf74f7 into storybookjs:next Nov 15, 2019
@rbardini rbardini deleted the fix-addon-viewport-types branch November 16, 2019 08:52
@shilman shilman mentioned this pull request Nov 16, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 30, 2019
shilman added a commit that referenced this pull request Nov 30, 2019
@shilman
Addon-viewports: Fix missing TypeScript types (#8848)
6c27b63 
Addon-viewports: Fix missing TypeScript types
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen ndelangen approved these changes

@saponifi3d saponifi3d Awaiting requested review from saponifi3d

Assignees
No one assigned
Labels
addon: viewport bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Milestone
5.2.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rbardini @shilman @ndelangen