Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Check module type in configure #8412

Merged
merged 2 commits into from Oct 18, 2019
Merged

Core: Check module type in configure #8412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf18850
Core: Check module type in configure
shilman Oct 14, 2019
cce0d28
Fix typo
shilman Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/core/src/client/preview/start.js
View file
Open in desktop
Expand Up @@ -440,6 +440,11 @@ export default function start(render, { decorateStory } = {}) {
* @param {*} framework - name of framework in use, e.g. "react"
*/
const configure = (loadable, m, framework) => {
if (typeof m === 'string') {
throw new Error(
`Invalid module '${m}'. Did you forget to pass \`module\` as the second argument to \`configure\`"?`
);
}
if (m && m.hot && m.hot.dispose) {
({ previousExports = new Map() } = m.hot.data || {});

Expand Down