Skip to content

Remove min-height CSS rule from DocsPage wrapper #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Remove min-height CSS rule from DocsPage wrapper #8366

merged 1 commit into from
Nov 1, 2019

Conversation

apust
Copy link
Contributor

@apust apust commented Oct 10, 2019

Even when content inside DocsPage has significantly less height than browser's viewport, is still shows a scrollbar that scrolls through empty space.

@vercel
Copy link

vercel bot commented Oct 10, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-apust-fix-docspage-remove-min-height.storybook.now.sh

@shilman shilman self-assigned this Oct 10, 2019
@shilman shilman added addon: docs bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 10, 2019
@stale
Copy link

stale bot commented Oct 31, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Oct 31, 2019
@shilman
Copy link
Member

shilman commented Oct 31, 2019

@domyen can you take a quick look at this?

@stale stale bot removed the inactive label Oct 31, 2019
@domyen
Copy link
Member

domyen commented Oct 31, 2019

@apust This style exists because we want the background to extend the full height of the iframe.

Can you confirm that the solution works in these contexts:

  • docs-only DocsPage
  • DocsPage in the docs tab
  • Light and dark themes

@apust
Copy link
Contributor Author

apust commented Nov 1, 2019

@domyen I can confirm the solution does not break background styles in these cases:

  • docs-only page
  • docs tab
  • light and dark themes
  • docs pages shorter and taller than viewport height

@domyen
Copy link
Member

domyen commented Nov 1, 2019

Checked it out in Chromatic. lgtm.

@shilman
Copy link
Member

shilman commented Nov 1, 2019

Merging. Thanks @apust @domyen !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants