-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Remove min-height CSS rule from DocsPage wrapper #8366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-apust-fix-docspage-remove-min-height.storybook.now.sh |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
@domyen can you take a quick look at this? |
@apust This style exists because we want the background to extend the full height of the iframe. Can you confirm that the solution works in these contexts:
|
@domyen I can confirm the solution does not break background styles in these cases:
|
Checked it out in Chromatic. lgtm. |
Remove min-height CSS rule from DocsPage wrapper
Even when content inside DocsPage has significantly less height than browser's viewport, is still shows a scrollbar that scrolls through empty space.