Skip to content

ADD cli test in github actions #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 4, 2019
Merged

Conversation

ndelangen
Copy link
Member

Issue: -cli test run in travis, but always, even if unchanged-

What I did

I changed the github actions workflow so that there's a workflow for the cli tests

@ndelangen ndelangen added maintenance User-facing maintenance tasks cli labels Sep 12, 2019
@ndelangen ndelangen self-assigned this Sep 12, 2019
@vercel
Copy link

vercel bot commented Sep 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-cli-tests-in-github-action.storybook.now.sh

@ndelangen ndelangen force-pushed the tech/cli-tests-in-github-action branch from a42b2f3 to 5d43e2b Compare September 12, 2019 14:32
@vercel vercel bot temporarily deployed to staging September 12, 2019 14:33 Inactive
@vercel vercel bot temporarily deployed to staging September 12, 2019 14:35 Inactive
@vercel vercel bot temporarily deployed to staging September 12, 2019 14:38 Inactive
@vercel vercel bot temporarily deployed to staging September 12, 2019 14:54 Inactive
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [10]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we upgrading? i thought we were on node8, tho maybe i'm misremembering. i'm fine to upgrade

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node is is EOL jan 2020

I could change it to 8 if you'd like

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can only change node support in major releases

Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there's much sense in running those tests on changes in core and other packages. There are ways to make the output of cli broken without touching cli code. Basically, those tests can discover hidden breaking changes

@vercel vercel bot temporarily deployed to staging October 4, 2019 08:39 Inactive
@ndelangen
Copy link
Member Author

@Hypnosphi I read you loud and clear. I've changed the config so it only runs on if there's a change in /lib or /app

I don't think a change in /addons would ever require a run of the cli tests.. Do you agree?

@shilman fixed

@vercel vercel bot temporarily deployed to staging October 4, 2019 09:43 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 09:45 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 10:54 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 10:55 Inactive
@vercel vercel bot temporarily deployed to staging October 4, 2019 10:57 Inactive
@ndelangen
Copy link
Member Author

Sure. We don't have any pre-installed addons, right?

addon links & actions are installed by default when you use sb init

@ndelangen
Copy link
Member Author

I had to disable the paths filtering for now because:
https://github.community/t5/GitHub-Actions/Preserve-status-from-previous-action-run/m-p/33821#M1661

@ndelangen
Copy link
Member Author

I've removed the cache from travis, it spends ages storing those, I wonder whether it's a net loss.

@ndelangen
Copy link
Member Author

Depending on which is faster GitHub actions or Travis, I'll keep either one for these tests.

If GitHub actions is faster, I might repurpose travis to do some other CI stuff.

@ndelangen ndelangen changed the title ADD cli test in github action (should only run if cli actually changed) ADD cli test in github actions Oct 4, 2019
@ndelangen
Copy link
Member Author

Screenshot 2019-10-04 at 14 58 41

VS

Screenshot 2019-10-04 at 14 59 00

@ndelangen
Copy link
Member Author

GitHub as a few minutes faster, sadly the tests will have to run on all commits, merging this, and disabling Travis for now. I'll repurpose it for something at some point

@vercel vercel bot temporarily deployed to staging October 4, 2019 13:06 Inactive
@ndelangen ndelangen force-pushed the tech/cli-tests-in-github-action branch from 1db5cff to dc6ac24 Compare October 4, 2019 13:11
@ndelangen ndelangen merged commit d0381ef into next Oct 4, 2019
@ndelangen ndelangen deleted the tech/cli-tests-in-github-action branch October 4, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants