-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
ADD cli test in github actions #8064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-tech-cli-tests-in-github-action.storybook.now.sh |
a42b2f3
to
5d43e2b
Compare
8319012
to
07faf06
Compare
.github/workflows/tests-cli.yml
Outdated
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
node-version: [10] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we upgrading? i thought we were on node8, tho maybe i'm misremembering. i'm fine to upgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node is is EOL jan 2020
I could change it to 8 if you'd like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can only change node support in major releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there's much sense in running those tests on changes in core
and other packages. There are ways to make the output of cli broken without touching cli code. Basically, those tests can discover hidden breaking changes
@Hypnosphi I read you loud and clear. I've changed the config so it only runs on if there's a change in /lib or /app I don't think a change in /addons would ever require a run of the cli tests.. Do you agree? @shilman fixed |
addon links & actions are installed by default when you use |
I had to disable the paths filtering for now because: |
I've removed the cache from travis, it spends ages storing those, I wonder whether it's a net loss. |
Depending on which is faster GitHub actions or Travis, I'll keep either one for these tests. If GitHub actions is faster, I might repurpose travis to do some other CI stuff. |
GitHub as a few minutes faster, sadly the tests will have to run on all commits, merging this, and disabling Travis for now. I'll repurpose it for something at some point |
1db5cff
to
dc6ac24
Compare
Issue: -cli test run in travis, but always, even if unchanged-
What I did
I changed the github actions workflow so that there's a workflow for the cli tests