Skip to content

UI: Improved component nav UI #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2019
Merged

UI: Improved component nav UI #7716

merged 3 commits into from
Aug 9, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 8, 2019

Issue: #6644

What I did

Improved Storybook's navigation UI to help with SB docs-related UI needs. Clicking on components now automatically selects the component's first story, like this:

updated-nav-ui

Expand & collapse of folders works the same as before.

How to test

cd examples/official-storybook
yarn storybook

@vercel
Copy link

vercel bot commented Aug 8, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@shilman shilman requested a review from domyen August 8, 2019 04:05
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@shilman
Copy link
Member Author

shilman commented Aug 8, 2019

If a component is open, clicking on the component should NOT take you to the first story of that component and it should just collapse instead.

Copy link
Member

@domyen domyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shilman and I chatted in person, feedback:

If a component is open, clicking on the component should NOT take you to the first story of that component and it should just collapse instead.

Otherwise makes sense to me especially with the new docs features.

@shilman shilman merged commit d0bf6b1 into next Aug 9, 2019
@shilman shilman deleted the 6644-new-nav-ui branch August 9, 2019 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants