Core: Disable CRA behaviors when preset detected #7696
Merged
+35
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
shilman
reviewed
Aug 6, 2019
shilman
reviewed
Aug 6, 2019
| @@ -27,7 +29,7 @@ export function managerWebpack(config: Configuration) { | |||
| } | |||
|
|
|||
| export function babelDefault(config: Configuration) { | |||
| if (!isReactScriptsInstalled()) { | |||
| if (!isReactScriptsInstalled() || !builtInPresetDisabled) { | |||
There was a problem hiding this comment.
should be || builtInPresetDisabled?
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
f212bad to
40d3cdf
Compare
shilman
approved these changes
Aug 6, 2019
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
40d3cdf to
38c2259
Compare
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
5c1b1bf to
918ab1f
Compare
mrmckeb
changed the title
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
918ab1f to
6f8ef44
Compare
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
6f8ef44 to
7276957
Compare
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
7276957 to
1050707
Compare
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
1050707 to
012d41c
Compare
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
012d41c to
c9ca61f
Compare
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
c9ca61f to
d377340
Compare
mrmckeb
force-pushed
the
feature/disable-cra-preset
branch
from
d377340 to
dedaa6d
Compare
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the built-in CRA preset for
@storybook/reactwhen the new preset is detected.Relates to storybookjs/presets#25.