Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove project root babel.config.js loading #7573

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 26, 2019

Issue: #7058

What I did

Revert unintentional breaking change and document in MIGRATION.md

How to test

Add a babel.config.js to your .storybook directory

@shilman shilman added BREAKING CHANGE patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jul 26, 2019
@shilman shilman added this to the 5.1.x milestone Jul 26, 2019
@vercel
Copy link

vercel bot commented Jul 26, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-7058-fix-babel-config.storybook.now.sh

@github-actions
Copy link
Contributor

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 236c5ac

@shilman shilman merged commit 19618ad into next Jul 26, 2019
@shilman shilman deleted the 7058-fix-babel-config branch July 26, 2019 11:32
shilman added a commit that referenced this pull request Jul 31, 2019
Core: Remove project root `babel.config.js` loading
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants