Addon-centered/contexts: Move optionalDependencies to peerDependencies #7315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise NPM will install these packages, causing bloat
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-7087-fix-centered-deps.storybook.now.sh |
shilman
added
the
patch:yes
ndelangen
approved these changes
Jul 5, 2019
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jul 31, 2019
Addon-centered/contexts: Move optionalDependencies to peerDependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7087
What I did
According to #7087
addon-centeredinstalls unneeded packages. The packages in question are listed asoptionalDependencies.Now users will get warnings about missing peer deps, but their build won't blow up. I think this is the better tradeoff?
How to test
CI?