Fix unstretched preview background wrapper #7173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fork-autarc-fix-stretch-preview-background-wrapper.storybook.now.sh |
shilman
added
addon: viewport
bug
ui
patch:yes
ndelangen
approved these changes
Jun 23, 2019
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jul 31, 2019
Fix unstretched preview background wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Currently the styled
Backgroundcomponent which wraps the iframe with previews doesn't stretch completely. It takes the height of the viewport even if the content might be larger. While this is normally not an issue it can cause an unexpected behavior if the backgrounds and the viewport addon are used together. This PR changes the CSS attribute fromheighttomin-heightto cover cases like this as well.