Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addons-info): change stylesheetBase info height from 110vh to 100vh #7141

Merged
merged 1 commit into from
Jun 18, 2019
Merged

fix(addons-info): change stylesheetBase info height from 110vh to 100vh #7141

merged 1 commit into from
Jun 18, 2019

Conversation

jendowns
Copy link
Contributor

@jendowns jendowns commented Jun 18, 2019

Resolves #7140

What I did

In this case, changing the height from 110vh to 100vh fixes the issue identified in #7140, where the last propTypes table in a given "Info" pane/section gets cut off for any component you view.

Please let me know if you need more info from me about this issue, if you disagree, or if you prefer a different fix.

We identified this issue originally in our internal storybook when upgrading from the stable release to v5.2.0-alpha.28 (in order to get the code block fixes 😅 )

How to test

  1. Check out this page in the PR deployment, for example: https://monorepo-git-fork-jendowns-patch-2.storybook.now.sh/examples/official-storybook/?path=/story/addons-info-markdown--displays-markdown-in-description
  2. Click "show info" and reduce your browser window height a bit so you get a scrollbar in the Info pane
  3. Scroll down, note that the last part of the propTypes table looks fine
  4. Inspect the "Info" pane & find the .info__overlay element
  5. Change height: 100vh to height: 110vh (previous value)
  6. Scroll up and down, note that the propTypes table is cut off at the bottom of the Info pane

@vercel
Copy link

vercel bot commented Jun 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-jendowns-patch-2.storybook.now.sh

@jendowns jendowns changed the title fix(addons-info): change stylesheetBase info from 110vh to 100vh fix(addons-info): change stylesheetBase info height from 110vh to 100vh Jun 18, 2019
@shilman shilman added addon: info bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 18, 2019
@shilman shilman added this to the 5.1.x milestone Jun 18, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

@shilman shilman merged commit 91a65a8 into storybookjs:next Jun 18, 2019
@jendowns jendowns deleted the patch-2 branch June 18, 2019 21:06
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 31, 2019
shilman added a commit that referenced this pull request Jul 31, 2019
…vh (#7141)

fix(addons-info): change stylesheetBase info height from 110vh to 100vh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: info bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addons-info stylesheetBase sets info to height: 110vh which cuts off propTypes table
2 participants