Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: replaced merge-dirs dependency by fs-extra #7100

Merged
merged 2 commits into from
Jun 16, 2019
Merged

cli: replaced merge-dirs dependency by fs-extra #7100

merged 2 commits into from
Jun 16, 2019

Conversation

debel27
Copy link
Contributor

@debel27 debel27 commented Jun 15, 2019

Issue: #4241

What I did

I replaced the merge-dirs dependency by fs-extra.
See #4241 for more information

How to test

  • Is this testable with Jest or Chromatic screenshots? Can't say (but I guess so)
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Jun 15, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-debel27-next.storybook.now.sh

@ndelangen
Copy link
Member

Thanks for this, seems like the lockfile has to be updated for the CI to approve,

I can do that too monday, unless you feel like doing it.

Should be as simple as running yarn and committing the new yarn.lock

@ndelangen ndelangen added this to the 5.1.x milestone Jun 15, 2019
@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 15, 2019
@debel27
Copy link
Contributor Author

debel27 commented Jun 15, 2019

Hey @ndelangen,

I can surely do it, but the cli package didn't have any yarn.lock to begin with. Should I generate one from scratch using yarn ?

Thanks for adding the required labels, I was unsure to have to proper rights to do so.

@debel27
Copy link
Contributor Author

debel27 commented Jun 15, 2019

I upgraded the yarn.lock at the root of the project. The dependency change is located in the cli package.json though, so I don't think it will make much of a difference.

Sorry, I'm unfamiliar with monorepos.

@ndelangen
Copy link
Member

@debel27 you nailed it!

@ndelangen ndelangen merged commit a742984 into storybookjs:next Jun 16, 2019
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 31, 2019
shilman pushed a commit that referenced this pull request Jul 31, 2019
cli: replaced merge-dirs dependency by fs-extra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants