Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate addon a11y to TS #5738

Merged
merged 7 commits into from
Mar 7, 2019
Merged

Migrate addon a11y to TS #5738

merged 7 commits into from
Mar 7, 2019

Commits on Mar 7, 2019

  1. chore: add tsconfig in addons/a11y

    @gaetanmaisse
    gaetanmaisse committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    e4cf45c View commit details
    Browse the repository at this point in the history

  2. chore: migrate src of addons/a11y to Typescript

    @gaetanmaisse
    gaetanmaisse committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    76029c9 View commit details
    Browse the repository at this point in the history

  3. chore: type src of addons/a11y

    @gaetanmaisse
    gaetanmaisse committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    d7ad26e View commit details
    Browse the repository at this point in the history

  4. chore: remove prop-types dependency from package.json of addons/a11y

    @gaetanmaisse
    gaetanmaisse committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    e913428 View commit details
    Browse the repository at this point in the history

  5. chore: use named import/export instead of default ones in addons/a11y

    @gaetanmaisse
    gaetanmaisse committed Mar 7, 2019
    1 Configuration menu
    Copy the full SHA
    a22b88e View commit details
    Browse the repository at this point in the history

  6. refactor: use a class property to prevent performance issue 

    See https://reactjs.org/docs/faq-functions.html#arrow-function-in-render
And https://reactjs.org/docs/faq-functions.html#class-properties-stage-3-proposal
    @gaetanmaisse
    gaetanmaisse committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    f3a0ad6 View commit details
    Browse the repository at this point in the history

  7. fix: fix a11y option attribute in examples/official-storybook

    @gaetanmaisse
    gaetanmaisse committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    1c013a3 View commit details
    Browse the repository at this point in the history