Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate addon actions to TS #5459

Merged
merged 6 commits into from Feb 9, 2019
Merged

Migrate addon actions to TS #5459

merged 6 commits into from Feb 9, 2019

Conversation

gaetanmaisse
Copy link
Member

Issue:

#5030

What I did

  • Migrated @storybook/addon-actions to TypeScript
  • Refactor some import/export
  • Add some type and interface and use them to type codebase

@gaetanmaisse
Copy link
Member Author

Broken tests should be fixed when #5457 will be merged.

addons/actions/package.json Outdated Show resolved Hide resolved
addons/actions/package.json Show resolved Hide resolved
addons/actions/src/components/ActionLogger/index.tsx Outdated Show resolved Hide resolved
addons/actions/src/containers/ActionLogger/index.tsx Outdated Show resolved Hide resolved
addons/actions/src/containers/ActionLogger/index.tsx Outdated Show resolved Hide resolved
@wuweiweiwu wuweiweiwu added maintenance User-facing maintenance tasks addon: actions labels Feb 4, 2019
@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #5459 into next will increase coverage by 0.19%.
The diff coverage is 67.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5459      +/-   ##
==========================================
+ Coverage   32.91%   33.11%   +0.19%     
==========================================
  Files         638      638              
  Lines        9236     9263      +27     
  Branches     1334     1318      -16     
==========================================
+ Hits         3040     3067      +27     
- Misses       5557     5570      +13     
+ Partials      639      626      -13
Impacted Files Coverage Δ
addons/actions/src/constants.ts 100% <ø> (ø)
addons/actions/src/manager.tsx 0% <0%> (ø)
...dons/actions/src/components/ActionLogger/index.tsx 0% <0%> (ø)
...dons/actions/src/containers/ActionLogger/index.tsx 0% <0%> (ø)
addons/actions/src/preview/action.ts 100% <100%> (ø)
addons/actions/src/preview/index.ts 100% <100%> (ø)
addons/actions/src/preview/configureActions.ts 100% <100%> (ø)
addons/actions/src/preview/actions.ts 13.33% <50%> (ø)
addons/actions/src/preview/decorateAction.ts 30% <55.55%> (ø)
addons/actions/src/index.ts 75% <75%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b2144a...48169db. Read the comment docs.

@gaetanmaisse
Copy link
Member Author

@wuweiweiwu I resolved conflicts with next branch and I answered to your comments

@ndelangen ndelangen self-assigned this Feb 9, 2019
addons/actions/src/manager.tsx Outdated Show resolved Hide resolved
addons/actions/src/models/ActionDisplay.ts Outdated Show resolved Hide resolved
addons/actions/src/components/ActionLogger/index.tsx Outdated Show resolved Hide resolved
@ndelangen ndelangen merged commit 0b55a32 into storybookjs:next Feb 9, 2019
@ndelangen
Copy link
Member

Thank you @gaetanmaisse, awesome PR!

Thanks for the reviews @Keraito @wuweiweiwu !

@ndelangen ndelangen added this to the v5.0.0 milestone Feb 9, 2019
@shilman shilman removed this from the v5.0.0 milestone Feb 15, 2019
@gaetanmaisse gaetanmaisse deleted the ts-migration/addon-actions branch February 18, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: actions maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants