Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the node-logger version in app/react #4539

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Fix the node-logger version in app/react #4539

merged 1 commit into from
Oct 24, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Oct 24, 2018

@igor-dv igor-dv added maintenance User-facing maintenance tasks react labels Oct 24, 2018
@igor-dv igor-dv self-assigned this Oct 24, 2018
@codecov
Copy link

codecov bot commented Oct 24, 2018 •
edited

Codecov Report

Merging #4539 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4539   +/-   ##
=======================================
  Coverage   35.58%   35.58%           
=======================================
  Files         557      557           
  Lines        6730     6730           
  Branches      883      883           
=======================================
  Hits         2395     2395           
  Misses       3876     3876           
  Partials      459      459

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d82766...bed5a86. Read the comment docs.

shilman
shilman approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 4ccaf9f into master Oct 24, 2018
@shilman shilman deleted the fix-node-logger-version branch October 24, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@thomasbertet thomasbertet Awaiting requested review from thomasbertet thomasbertet is a code owner

Assignees

@igor-dv igor-dv

Labels
maintenance User-facing maintenance tasks react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igor-dv @shilman