Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HtmlWebpackPlugin error #3328

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Fix HtmlWebpackPlugin error #3328

merged 2 commits into from
Apr 2, 2018

Conversation

Hypnosphi
Copy link
Member

Issue: #3148 (comment)

@peet86 is there any reproduction code that we could add to our examples to check that the fix works?

@codecov
Copy link

codecov bot commented Mar 31, 2018

Codecov Report

Merging #3328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3328   +/-   ##
=======================================
  Coverage   35.63%   35.63%           
=======================================
  Files         472      472           
  Lines       10122    10122           
  Branches      956      945   -11     
=======================================
  Hits         3607     3607           
- Misses       5899     5925   +26     
+ Partials      616      590   -26
Impacted Files Coverage Δ
app/vue/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/polymer/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/mithril/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
...p/polymer/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/vue/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/react/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
...p/mithril/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/angular/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
...p/angular/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/react/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2675c19...f8fc80f. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 5f2304c into master Apr 2, 2018
@Hypnosphi Hypnosphi deleted the chunks-sort-mode-none branch April 2, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants