Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Support v19 betas in peer dependencies #26960

Merged
merged 14 commits into from May 6, 2024

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Apr 26, 2024

What I did

  • Added sandboxes for React prereleases, Vite and Webpack. Generation triggered at https://github.com/storybookjs/storybook/actions/runs/8845643521/job/24289949895
  • Expanded React peer deps version ranges to match. Isn't 100% perfect though since we still have transitive dependencies that doesn't specify v19, automatically narrowing it down to 18 still.
  • Converted defaultProps to default assignments in functional components where it was easy. React 19 ignores defaultProps, and we had a story that broke because of our usage of it .

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Apr 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 638b96a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold JReinhold self-assigned this Apr 26, 2024
@JReinhold JReinhold added react build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 26, 2024
@JReinhold JReinhold changed the title Sandboxes: Add React prerelease sandboxes React: Support v19 betas in peer dependencies Apr 26, 2024
@JReinhold JReinhold added maintenance User-facing maintenance tasks and removed build Internal-facing build tooling & test updates labels Apr 26, 2024
@JReinhold JReinhold marked this pull request as ready for review May 6, 2024 11:38
scripts/utils/yarn.ts Outdated Show resolved Hide resolved
@ndelangen ndelangen self-requested a review May 6, 2024 12:05
@JReinhold JReinhold merged commit 6a6da24 into next May 6, 2024
110 of 113 checks passed
@JReinhold JReinhold deleted the jeppe/react-prerelease-sandboxes branch May 6, 2024 14:11
@github-actions github-actions bot mentioned this pull request May 6, 2024
19 tasks
storybook-bot pushed a commit that referenced this pull request May 6, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
@github-actions github-actions bot mentioned this pull request May 6, 2024
6 tasks
storybook-bot pushed a commit that referenced this pull request May 6, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 6, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 7, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
storybook-bot pushed a commit that referenced this pull request May 8, 2024
…dboxes

React: Support v19 betas in peer dependencies
(cherry picked from commit 6a6da24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants