Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-actions: Fix falsy args printing as object - 22163 #26917

Merged
merged 3 commits into from Apr 29, 2024

Conversation

Fatcat560
Copy link
Contributor

@Fatcat560 Fatcat560 commented Apr 22, 2024

Closes #22163

What I did

This PR tries to resolve some inconsistent behaviour while using falsy values along with the actions addon.

Previously, arguments which evaluate to false would be printed by the actions addon as an object to the actions console:
behaviour_prev_bool

This also caused an issue with countdowns. Number printing would only work as expected until one hits the 0 mark:
behaviour_prev_num

With this PR, even falsy arguments print to the actions console as one would expect:
behaviour_new_bool
behaviour_new_num

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Modify the Type Boolean basic story in addons/actions/basics so that it randomly returns a boolean instead of a static one.
  2. Start storybook as described in the contributing guide.
  3. Open Storybook in your browser
  4. Access the previously modified story and click the button multiple times so that both boolean values have been logged to the console.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Apr 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bbafa40. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kasperpeulen kasperpeulen merged commit 28eb522 into storybookjs:next Apr 29, 2024
51 checks passed
@Fatcat560 Fatcat560 deleted the 22163_logEventFalseyFix branch April 29, 2024 16:12
@github-actions github-actions bot mentioned this pull request May 3, 2024
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants