Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Update meta title error handling #26911

Open
wants to merge 8 commits into
base: next
Choose a base branch
from
+4 −0
Open

Fix : Update meta title error handling #26911

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
746448e
Fix error message handling final slash in title
sossost Apr 22, 2024
6b79cc8
Merge branch 'next' into fix/error-message-final-slash-in-title
sossost Apr 25, 2024
484c38c
Merge branch 'next' into fix/error-message-final-slash-in-title
sossost Apr 27, 2024
01430a5
Merge branch 'next' into fix/error-message-final-slash-in-title
sossost Apr 30, 2024
dc5ee4f
Merge branch 'next' into pr/sossost/26911
ndelangen May 2, 2024
8014460
fix: clarify error messaging for title validation in path generation
sossost May 4, 2024
1b90958
Merge branch 'fix/error-message-final-slash-in-title' of https://gith…
sossost May 4, 2024
6aac1c3
Merge branch 'next' into fix/error-message-final-slash-in-title
sossost May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions code/lib/manager-api/src/lib/stories.ts
View file
Open in desktop
Expand Up @@ -193,6 +193,10 @@ export const transformStoryIndexToStoriesHash = (
const parent = idx > 0 && list[idx - 1];
const id = sanitize(parent ? `${parent}-${name}` : name!);

if (name.trim() === '') {
throw new Error(dedent`Invalid title ${title} ending in slash.`);
}

if (parent === id) {
throw new Error(
dedent`
Expand Down