Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Implement next redirect and the RedirectBoundary #26886

Merged
merged 18 commits into from May 3, 2024

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Apr 19, 2024

What I did

Implement next redirect and the RedirectBoundary

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26886-sha-76a14be0. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26886-sha-76a14be0 sandbox or in an existing project with npx storybook@0.0.0-pr-26886-sha-76a14be0 upgrade.

More information
Published version 0.0.0-pr-26886-sha-76a14be0
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kasper/redirect-boundary
Commit 76a14be0
Datetime Wed May 1 14:03:08 UTC 2024 (1714572188)
Workflow run 8910327185

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26886

Copy link

nx-cloud bot commented Apr 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 514c37b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Will try out the functionality next week.

Needs tests, or stories.

@yannbf yannbf added the nextjs label Apr 29, 2024
@yannbf yannbf marked this pull request as draft April 29, 2024 13:20
@kasperpeulen kasperpeulen marked this pull request as ready for review May 1, 2024 12:10
@kasperpeulen kasperpeulen requested review from JReinhold, nuzzesick and yannbf and removed request for nuzzesick May 1, 2024 12:16
@storybook-bot
Copy link
Contributor

Failed to publish canary version of this pull request, triggered by @kasperpeulen. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/8909168353

Base automatically changed from kasper/module-mocking to next May 1, 2024 13:40
@kasperpeulen kasperpeulen merged commit 314fbd6 into next May 3, 2024
61 checks passed
@kasperpeulen kasperpeulen deleted the kasper/redirect-boundary branch May 3, 2024 09:24
@github-actions github-actions bot mentioned this pull request May 3, 2024
44 tasks
@shilman shilman changed the title Nextjs: Implement next redirect and the RedirectBoundary Next.js: Implement next redirect and the RedirectBoundary May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants