Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add docs for story tags #26715

Merged
merged 7 commits into from May 7, 2024
Merged

Docs: Add docs for story tags #26715

merged 7 commits into from May 7, 2024

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Apr 2, 2024

What I did

Documented the newly-official tags API in #26634

Checklist for Contributors

Testing

Manual testing

  1. Follow the steps in the contributing instructions for this branch, tags-docs
  2. Check the new/updated pages
    1. http://localhost:8000/docs/writing-stories/tags
    2. http://localhost:8000/docs/writing-docs/autodocs

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

- API reference
- Guide
- CLI options
@kylegach kylegach self-assigned this Apr 2, 2024
Copy link

nx-cloud bot commented Apr 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 974ad92. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

- Document new API
- Add examples
- Remove `main-config-tags`
- Remove `--tags` and `--exclude-tags` CLI flags
- Remove `autodocs: true | false | 'tag'`
- Remove old snippets
@kylegach kylegach added the ci:docs Run the CI jobs for documentation checks only. label May 6, 2024
@kylegach kylegach marked this pull request as ready for review May 6, 2024 23:06
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great copy! Great examples! 💯

@shilman
Copy link
Member

shilman commented May 6, 2024

Note: let's wait to merge until the tags PR gets merged

@kylegach
Copy link
Contributor Author

kylegach commented May 7, 2024

Note: let's wait to merge until the tags PR gets merged

@shilman — Should I just update the target branch to yours?

@shilman
Copy link
Member

shilman commented May 7, 2024

@kylegach SGTM!

@kylegach kylegach changed the base branch from next to shilman/add-tag-exclusion May 7, 2024 02:55
Base automatically changed from shilman/add-tag-exclusion to next May 7, 2024 16:00

## Applying tags

A tag can be any string, either the [built-in tags](#built-in-tags) or custom tags of your own design. To apply tags to a story, assign an array of strings to the `tags` property. Tags may be applied at the project, component (meta), or story levels.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important to point out the limitation on tags being static. Eg. no template strings, no concatenation, no dynamic creation, etc.
@shilman will know the exact details but AFAIK nothing besides a plain string is supported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JReinhold — How's this?

34c0e17 (#26715)

@kylegach kylegach merged commit 4ea3fcf into next May 7, 2024
17 checks passed
@kylegach kylegach deleted the tags-docs branch May 7, 2024 19:01
@github-actions github-actions bot mentioned this pull request May 7, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants