Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember: Fix broken import #21580

Closed
wants to merge 6 commits into from
Closed

Conversation

yannbertrand
Copy link

Following #21435.

Hopefully closes #20653

What I did

Ember recommends to use @glimmer/component rather than @ember/component. I switched the import and the package.json accordingly. I believe ember itself somehow import @glimmer/component so maybe the peer dependency is not needed. I couldn't launch the project myself locally so let's wait for CI check.

How to test

  • Create a fresh app Ember
npx --package ember-cli ember --version #ember-cli: 4.11.0
npx --package ember-cli ember new ember-quickstart
  • Check Ember app works fine
cd ember-quickstart
npm start
  • Install this storybook PR for Ember
npm install --save-dev yannbertrand/storybook#main
  • Init Storybook
npx storybook --version #6.5.16
npx storybook init
  • Hopefully this command now works and render something
npm run storybook

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@socket-security
Copy link

socket-security bot commented Mar 13, 2023

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

⚠️ New author

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Package New Author Previous Author Source
ember-cli-htmlbars@5.7.2 (upgraded) katiegengler rwjblue examples/ember-cli/package.json
Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ⚠️ 1 issue
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected malware ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore ember-cli-htmlbars@5.7.2

Powered by socket.dev

@yannbertrand
Copy link
Author

Tons of error when upgrading to Ember 3.25, I'm stopping my fix experimentation now.

@yannbertrand yannbertrand deleted the main branch March 14, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant